Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moo: raise error for size>10 #951

Merged
merged 1 commit into from
Feb 19, 2025
Merged

moo: raise error for size>10 #951

merged 1 commit into from
Feb 19, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Feb 19, 2025

  • The maximum number of distinct digits is 10
  • This version of moo takes an optional size argument
  • It is more correct to show an error if the requested size is invalid
  • Based on commit f3248c8 in bin/fish, add entropy thanks to hash keys being "unordered"

@mknos
moo: raise error for size>10
d1debfc 
* The maximum number of distinct digits is 10
* This version didn't raise an error for larger values of size parameter
* Based on commit f3248c8 in bin/fish, add entropy thanks to hash keys being "unordered"
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: moo The moo program labels Feb 19, 2025
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 01:22 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Feb 19, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13403448970

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.389%
Totals Coverage Status
Change from base Build 13285364908: 0.0%
Covered Lines: 353
Relevant Lines: 481
💛 - Coveralls

@briandfoy
Copy link
Owner

changes: raise error for size>10

@briandfoy briandfoy merged commit dc9d37b into briandfoy:master Feb 19, 2025
23 checks passed
@briandfoy briandfoy self-assigned this Feb 19, 2025
@briandfoy briandfoy added the Status: accepted The fix is accepted label Feb 19, 2025
@briandfoy briandfoy removed the Priority: low get to this whenever label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: moo The moo program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy